Set maximum unchecked blocks in config #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
reviewed
Jan 26, 2024
RickiNano
force-pushed
the
configurable-unchecked-blocks
branch
from
45c7b4f to
ce11ced
Compare
dsiganos
requested changes
Jan 28, 2024
|
You should add some code to check this new config in the test cases:
|
dsiganos
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the maximum number of unchecked blocks to store in memory configurable by using a new "max_unchecked_blocks" setting in config-node.toml. It defaults to 65536 blocks (the current hardcoded number)